[bisq-network/bisq] Autoconfirm XMR trade if tx check was validated by proof service (#4421)

[chimp1984]

@chimp1984 commented on this pull request.



> +                        if (confirmations < confirmsRequired)
+                            // we return TX_NOT_CONFIRMED which will cause a retry later
+                            return new XmrProofResult(confirmations, confirmsRequired, XmrProofResult.State.TX_NOT_CONFIRMED);
+                        else
+                            return new XmrProofResult(confirmations, confirmsRequired, XmrProofResult.State.PROOF_OK);
+                    }
+                }
+            }
+
+            // reaching this point means there was no matching amount
+            return new XmrProofResult(XmrProofResult.State.AMOUNT_NOT_MATCHING, null);
+
+            // TODO check if date of tx is after tradeDate (allow some tolerance to avoid clock sync issues).
+            //  Otherwise a scammer could send an old txKey from a prev trade with same amount before seller has
+            //  updated to new feature, thus the check for duplication would not detect the scam.
+            //  >>>>> the API does not provide date of tx <<<<<<

I think its just some edge case at update where this could be a risk. Does the API not provide the date? If not would you mind to ask the Monero dev if he can add it? I guess it would be a small change and would remove the described risk.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4421#discussion_r474328179
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200820/bbcb150e/attachment.html>