[bisq-network/bisq] Optimize AssetService (#4409)

sqrrm notifications at github.com
Fri Aug 21 17:07:22 UTC 2020


@sqrrm requested changes on this pull request.

Looks good. Would prefer to have pure refactoring as separate commits for easier review.

Added a couple of suggestions before merging.

Needs review from @ManfredKarrer since it touches core/dao

> +                log.info("Asset listing fee tx has been published. TxId={}", transaction.getHashAsString());
+                resultHandler.handleResult();
+            }
+
+            @Override
+            public void onFailure(TxBroadcastException exception) {
+                errorMessageHandler.handleErrorMessage(exception.getMessage());
+            }
+        });
+    }
+
+
+    ///////////////////////////////////////////////////////////////////////////////////////////
+    // Private
+    ///////////////////////////////////////////////////////////////////////////////////////////
+

```suggestion

    // Get the trade volume from lookupDate until current date
```

>      private void updateList() {
+        log.error("updateList");

```suggestion
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4409#pullrequestreview-472638723
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200821/a017ea50/attachment.html>


More information about the bisq-github mailing list