[bisq-network/bisq] Increase data request timeout (#4424)

chimp1984 notifications at github.com
Sun Aug 23 00:34:36 UTC 2020


At slow internet connections the current timeout make it impossible to
get the initial data and therefor to use Bisq.
The timeout is containing the request and response as well as the time
it takes to start up the network connection which can also be quite
slow.
In my scenario, it took about 6-10 sec for the connection and the
request is atm nearly 3 MB which takes about 24 sec on a 1 Mbit/s
connection (note that over tor connection is slower so if normal speed
is 3-5 Mbit tors speed can be considerable lower). The response data
depends on the missing data/last update but can be easily 6 MB which
adds about another 48 sec. So one can easily hit the 90 sec. limit.

There is work in development for optimizing the initial data request,
but as that is more complex and not clear when it will be deployed I
recommend that we increase the current timeout to 180 sec. to avoid
that critical issue that users get "locked out".
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4424

-- Commit Summary --

  * Increase timeout for data request
  * Change log level to make it more clear how long it takes for creating

-- File Changes --

    M p2p/src/main/java/bisq/network/p2p/network/NetworkNode.java (6)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/RequestDataHandler.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4424.patch
https://github.com/bisq-network/bisq/pull/4424.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4424
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200822/cbde64ee/attachment-0001.html>


More information about the bisq-github mailing list