[bisq-network/bisq] Autoconfirm XMR trade if tx check was validated by proof service (#4421)

James Cox notifications at github.com
Sun Aug 23 17:45:16 UTC 2020


@jmacxx commented on this pull request.



> @@ -279,6 +280,6 @@ public static PreferencesPayload fromProto(protobuf.PreferencesPayload proto, Co
                 proto.getBuyerSecurityDepositAsPercentForCrypto(),
                 proto.getBlockNotifyPort(),
                 proto.getTacAcceptedV120(),
-                proto.getAutoConfirmXmr());
+                AutoConfirmSettings.fromProto(userAutoConfirmSettings));

The check for null settings is handled by protobuf boilerplate code.  It creates a default instance of the settings object.

      return autoConfirmSettings_ == null ? protobuf.AutoConfirmSettings.getDefaultInstance() : autoConfirmSettings_;


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4421#discussion_r475246066
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200823/b60ffe8f/attachment.html>


More information about the bisq-github mailing list