[bisq-network/compensation] For Cycle 16 (#642)

[Stan]

@sqrrm @ripcurlx:
>> I have a hard time valuing this work...

I expected this valid questioning and pushback to the CR.  I can be flexible about the amount requested, but when I was ready to submit the PR about a month ago, I thought it was worth more than 10K USD.

Let me respond to your comments and give you my plan for the next phase of development.  Maybe it will help you decide to approve this CR as is, or not.

Although the `apitest` harness gives no benefits to Bisq users today, it can provide benefits to other code contributors now, and the test harness will benefit the ongoing work on the API, which I will talk about in a moment.

Below is a list of tasks I am currently working on, starting with the work already done, and saved in a [scratch branch](https://github.com/ghubstan/bisq/commits/api-scratch).

Finish and fix `apitest` functionality (already done, to go into new PRs but not to be compensated):

  *  Fix test case setup method to accept any combination of options
  *  Move :cli/test.sh to :apitest/scripts/mainnet-test.sh
  *  Remove duplicated gRPC stub creation logic
  *  Remove 3 redundant config options
  *  Add option to run background Bisq apps with remote debug options

Below are descriptions of two completed tasks I will add to new PRs, and be part of my next CR (Cycle 17):

1. I had to upgrade JFoenix to v9.0.10 in my [scratch branch](https://github.com/ghubstan/bisq/commit/96669bfe92f3522f671cc25e8d313190cc4d607b), to avoid an NPE being thrown when I try to register a dispute agent in an arb desktop running in regtest/dao mode.  I came across this JFoenix lib bug while using `apitest` to figure out how get the API to register dispute and refund agents -- required for trading with the API.
  
2. I completed one task directly related to the API, a new `ping` method to be used for checking server availability before any request.

The next task is figure out how, then implement registration of dispute and refund agents in an arbitration :daemon.

After that, I go back to the "simplest trading script" task list defined in [Issue 4257](https://github.com/bisq-network/bisq/issues/4257), and implmenent `creatoffer`, `confirmoffer`, `takeoffer`, `confirmtakeoffer`, `getofferstatus`, `paymentstarted`, `paymentreceived`, `canceloffer`, `movefunds`, and `withdrawfunds` methods and test cases.

Now that `apitest` is out of the way, I can focus on the "simple api trading" script work again.  I do think I have a good chance of implementing all or most of these new methods in the next 3-4 weeks (if `apitest` is truly "out of the way").  This is when the benefits of `apitest` will become more tangible.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/642#issuecomment-679189252
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200824/2266cd73/attachment.html>