[bisq-network/bisq] Move gRPC boilerplate from :core to :daemon (#4427)

Stan notifications at github.com
Mon Aug 24 18:36:27 UTC 2020


This change moves `gRPC` boilerplate code from the `:core.grpc` pkg into a new `:daemon.grpc` pkg.

* The `:core.grpc` pkg was renamed `:core.api`, and no longer has a dependency on `gRPC` libs.

* All core service classes in the `:core.api` pkg are now package protected, excepting `CoreApi`, making `CoreApi` the only possible entry point for all `Grpc*Service -> Core*Service` calls.

* All `gRPC` service classes in the `:daemon.grpc` pkg are now package protected, excepting `GrpcServer`;  the only class depending on `Grpc*Service` class is `GrpcServer`.

* `gRPC` dependencies were moved from the `gradle.build` file's `:core` subproject to `:daemon`.

This PR replaces [4417](https://github.com/bisq-network/bisq/pull/4417).
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4427

-- Commit Summary --

  * Move gRPC boilerplate from :core to :daemon

-- File Changes --

    M build.gradle (17)
    R core/src/main/java/bisq/core/api/CoreApi.java (4)
    R core/src/main/java/bisq/core/api/CoreOffersService.java (4)
    R core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (4)
    R core/src/main/java/bisq/core/api/CoreWalletsService.java (4)
    R core/src/main/java/bisq/core/api/model/AddressBalanceInfo.java (2)
    R core/src/main/java/bisq/core/api/model/OfferInfo.java (2)
    M daemon/src/main/java/bisq/daemon/app/BisqDaemonMain.java (8)
    R daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (5)
    R daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (5)
    R daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java (3)
    R daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (5)
    R daemon/src/main/java/bisq/daemon/grpc/PasswordAuthInterceptor.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4427.patch
https://github.com/bisq-network/bisq/pull/4427.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4427
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200824/70c513ce/attachment.html>


More information about the bisq-github mailing list