[bisq-network/bisq] Autoconfirm XMR trade if tx check was validated by proof service (#4421)

[James Cox]

@jmacxx commented on this pull request.



> @@ -2493,8 +2506,8 @@ showWalletDataWindow.walletData=Wallet data
 showWalletDataWindow.includePrivKeys=Include private keys
 
 setXMRTxKeyWindow.headline=Prove sending of XMR
-setXMRTxKeyWindow.txHash=Transaction hash
-setXMRTxKeyWindow.txKey=Tx private key
+setXMRTxKeyWindow.txHash=Transaction id
+setXMRTxKeyWindow.txKey=Tx key

How about "Transaction key" instead?  The term "private key" always raises red flags because we are conditioned to never reveal our private keys.  

- https://www.getmonero.org/resources/user-guides/prove-payment.html refers to it as "the transaction's key".  Their web form calls it a "secret transaction key", slightly less intimidating without the word private.
- monero-wallet-cli also calls it tx key: `get_tx_key TXID`
- https://monero.stackexchange.com/questions/1860/how-do-i-prove-that-a-payment-has-been-sent-to-a-particular-address/1861 they call it transaction key.
- https://github.com/moneroexamples/onion-monero-blockchain-explorer calls it `viewkey`.
- Bisq's contract text for XMR account creation calls it `Transaction key` three times, and also gives synonyms `Tx Key, Tx Secret Key or Tx Private Key`
- https://xmr.llcoins.net/checktx.html does use "private key" though.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4421#discussion_r476548189
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200825/9a28d2fc/attachment.html>