[bisq-network/bisq] Fix setUpScaffold() signature (#4429)
Stan
notifications at github.com
Tue Aug 25 16:15:22 UTC 2020
Adds the missing String[] params to the method signature, so test cases can pass any needed combination of options to the scaffolding setup from a `@BeforeAll` method.
<!--
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->
_PR 1 of 5, to be reviewed/merged in PR number order._
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4429
-- Commit Summary --
* Fix setUpScaffold() signature
-- File Changes --
M apitest/src/test/java/bisq/apitest/ApiTestCase.java (4)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4429.patch
https://github.com/bisq-network/bisq/pull/4429.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4429
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200825/542885be/attachment.html>
More information about the bisq-github
mailing list