[bisq-network/bisq] Remove duplicated grpc stub creation logic (#4431)
Stan
notifications at github.com
Tue Aug 25 16:19:35 UTC 2020
The `:apitest GrpcStubs` class was removed and recreated in the `:cli` subproject, to be used by both `:cli` and `:apitest`. `CliMain` was changed to use the new `GrpcStubs`.
_PR 3 of 5, to be reviewed/merged in PR number order._
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4431
-- Commit Summary --
* Fix setUpScaffold() signature
* Move :cli test.sh to :apitest mainnet-test.sh
* Remove duplicated grpc stub creation logic
-- File Changes --
R apitest/scripts/mainnet-test.sh (14)
M apitest/src/test/java/bisq/apitest/ApiTestCase.java (13)
D apitest/src/test/java/bisq/apitest/GrpcStubs.java (109)
M cli/src/main/java/bisq/cli/CliMain.java (20)
A cli/src/main/java/bisq/cli/GrpcStubs.java (54)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4431.patch
https://github.com/bisq-network/bisq/pull/4431.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4431
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200825/3ff00dac/attachment.html>
More information about the bisq-github
mailing list