[bisq-network/bisq] Remove redundant ApiTestConfig options (#4432)

[Stan]

This change removes three `:apitest` scaffold setup options: `runArbNodeAsDesktop`, `runAliceNodeAsDesktop`, and `runBobNodeAsDesktop`, which should have  been deleted when the `supportingApps` option was added.  The comma delimited list of apps passed with the `supportingApps` option now determines whether `arbitration` / `bob` / `alice` nodes are started as desktops or daemons.

_PR 4 of 5, to be reviewed/merged in PR number order._

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4432

-- Commit Summary --

  * Fix setUpScaffold() signature
  * Move :cli test.sh to :apitest mainnet-test.sh
  * Remove duplicated grpc stub creation logic
  * Remove redundant ApiTestConfig options

-- File Changes --

    R apitest/scripts/mainnet-test.sh (14)
    M apitest/src/main/java/bisq/apitest/Scaffold.java (26)
    M apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java (30)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (13)
    D apitest/src/test/java/bisq/apitest/GrpcStubs.java (109)
    M cli/src/main/java/bisq/cli/CliMain.java (20)
    A cli/src/main/java/bisq/cli/GrpcStubs.java (54)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4432.patch
https://github.com/bisq-network/bisq/pull/4432.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4432
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200825/8529652c/attachment.html>