[bisq-network/bisq] Allow remote debugging of background Bisq apps (#4433)

[Stan]

A unique hard coded debug listening port is assigned to the different Bisq app types in the `BisqAppConfig` enum, and background Bisq apps will be started with remote debug options if the scaffold-setup method is passed an `--enableBisqDebugging=true` option.

* Added `enableBisqDebugging` (default=false) option to `ApiTestConfig`.

* Added `remoteDebugPort` field to `BisqAppConfig` enum.

* Added `debugOpts` field to `BisqApp` (using `BisqAppConfig#remoteDebugPort`).

* Appends `debugOpts` to exported `JAVA_OPTS` environment variable if present.

* Removed messy quotes from `BisqAppConfig` enum `javaOpts` values.

* Removed redundant return statement from `BisqApp#shutdown()`.


_PR 5 of 5, to be reviewed/merged in PR number order._
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4433

-- Commit Summary --

  * Fix setUpScaffold() signature
  * Move :cli test.sh to :apitest mainnet-test.sh
  * Remove duplicated grpc stub creation logic
  * Remove redundant ApiTestConfig options
  * Allow remote debugging of background Bisq apps

-- File Changes --

    R apitest/scripts/mainnet-test.sh (14)
    M apitest/src/main/java/bisq/apitest/Scaffold.java (26)
    M apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java (39)
    M apitest/src/main/java/bisq/apitest/config/BisqAppConfig.java (42)
    M apitest/src/main/java/bisq/apitest/linux/BisqApp.java (7)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (13)
    D apitest/src/test/java/bisq/apitest/GrpcStubs.java (109)
    M cli/src/main/java/bisq/cli/CliMain.java (20)
    A cli/src/main/java/bisq/cli/GrpcStubs.java (54)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4433.patch
https://github.com/bisq-network/bisq/pull/4433.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4433
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200825/dab8c5ca/attachment.html>