[bisq-network/bisq] Add Tether token support via ERC20 and Omni (#4434)

Jelle Besseling notifications at github.com
Tue Aug 25 18:25:41 UTC 2020


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Related: https://github.com/bisq-network/proposals/issues/170, #2369

>From the proposal and the discussion in Keybase it is clear that the USDT token is wanted on Bisq. This PR adds basic support for the ERC20 based token and the Omni based token. 

I think a discussion should be had about the best way to make this implementation better. As of now, it adds two altcoins and thus two new markets are possible. I think it can be improved by joining these accounts or these markets in some way, for when users want to be able to trade both versions of USDT. On centralised markets there is only one USDT/XBT market, and the two tokens are considered equal. I think this behaviour is desirable.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4434

-- Commit Summary --

  * Add Tether token support via ERC20 and Omni

-- File Changes --

    A assets/src/main/java/bisq/asset/coins/TetherOmni.java (10)
    A assets/src/main/java/bisq/asset/tokens/TetherERC20.java (9)
    M assets/src/main/resources/META-INF/services/bisq.asset.Asset (2)
    M desktop/src/main/java/bisq/desktop/main/MainView.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4434.patch
https://github.com/bisq-network/bisq/pull/4434.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4434
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200825/654307aa/attachment-0001.html>


More information about the bisq-github mailing list