[bisq-network/bisq] Autoconfirm XMR trade if tx check was validated by proof service (#4421)

[m52go]

@m52go commented on this pull request.



> @@ -1240,9 +1244,11 @@ setting.about.shortcuts.sendFilter=Set Filter (privileged activity)
 setting.about.shortcuts.sendPrivateNotification=Send private notification to peer (privileged activity)
 setting.about.shortcuts.sendPrivateNotification.value=Open peer info at avatar or dispute and press: {0}
 
-setting.info.headline=New XMR Autoconfirm feature
-setting.info.msg=When selling BTC for XMR you can use the autoconfirm feature to verify that the correct amount of XMR has been deposited to your wallet and automatically confirm the trade, releasing BTC to the counterparty.\n\n\
-  This can make the trade process more efficient for both peers.  Limits can also be set on the max amount of BTC that can be auto-confirmed.  See the auto-confirm section on this page for more info and to enable the feature.
+setting.info.headline=New XMR Auto confirm feature
+setting.info.msg=When selling BTC for XMR you can use the auto confirm feature to verify that the correct amount of XMR has been deposited to your wallet and automatically confirm the trade, releasing BTC to the counterparty.\n\n\
+  This can make the trade process more efficient for both peers.  Limits can also be set on the max amount of BTC that can be auto-confirmed.  See the auto-confirm settings on this page for more info and to enable the feature.\n\n\
+  Auto confirmation relies on Bisq checking the XMR transaction on an explorer API.  For maximum security it is recommended that you point Bisq to your own explorer service, but there are also services available run by Bisq (the default setting).\n\n\
+  For more information and details on how to setup, see the blog post here: [.....]
 

This text assumes it will be shown on the settings screen:
```
setting.info.msg=When selling BTC for XMR you can use the auto-confirm feature to verify that the correct amount of 
XMR was sent to your wallet so that Bisq can automatically mark the trade as complete, making trades quicker for everyone.\n\n
Auto-confirm checks the XMR transaction on at least 2 XMR explorer nodes using the private transaction key provided 
by the XMR sender. By default, Bisq uses explorer nodes run by Bisq contributors, but we recommend running your
own XMR explorer node for maximum privacy and security.\n\n
You can also set the maximum amount of BTC per trade to auto-confirm as well as the number of required 
confirmations here in Settings.\n\n
See more details (including how to set up your own explorer node) on the Bisq wiki: [.....]
```
@jmacxx @chimp1984 is there a reference somewhere for how to set up an XMR explorer node?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4421#discussion_r477571774
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200826/16c79eb9/attachment-0001.html>