[bisq-network/bisq] Upgrade JFoenix to v9.0.10 (#4443)

[Stan]

> Does the update solve the issue? It might be that its some security policy violation if you start the app from another process. If so I expect there might follow more issues. I don't know the details of your setup though.

Yes, the upgrade does solve the issue.  Why it does is something I have not yet learned from examining JFoenix src and [JFoenix commit history](https://github.com/jfoenixadmin/JFoenix/commits/master).  There are also problems stepping through src in the debugger below `com.jfoenix.adapters.ReflectionHelper`, in `jdk.internal.*`.  

Not being able to find the answer directly from the JFoenix src made me fall back to others' reports.  There are statements about JFoenix not being compatible with JDK 11+:  an open JFoenix [PR](https://github.com/jfoenixadmin/JFoenix/pull/1110), and this [stackoverflow](https://stackoverflow.com/questions/55889654/illegalaccessexception-for-jfxtextfield-with-java-sdk-12) post describing the same problem I see (using JDK 11).  JFoenix [Issue 995](https://github.com/jfoenixadmin/JFoenix/issues/955) shows others seeing the same bug, with some upgrading and passing jvm `--add-opens` options to work around it.   I just needed to upgrade to resolve the issue.

JFoenix is still active, but not very.  I think Bisq will be forced to upgrade this dependency for JDK14, but JFoenix might be gradually removed in stages, first by reducing the dependency on reflection in our cloned JFoenix code.  There is an example of how to do some of that in PR [1110](https://github.com/jfoenixadmin/JFoenix/pull/1110)'s single  [commit](https://github.com/jfoenixadmin/JFoenix/pull/1110/commits/5c8bb4777202a0c79610fd2ee0e66e0e6276550c).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4443#issuecomment-683322736
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200829/3a5b500a/attachment-0001.html>