[bisq-network/bisq] Add support for user name for Revolut accounts (#4453)

chimp1984 notifications at github.com
Sun Aug 30 21:13:05 UTC 2020


If a user has an existing account with phone number or email as
account ID we show a popup at startup where we require that he sets the
user name. This popup has no close button so he is forced to enter a
value. If there are multiple account multiple popups will be shown.

To not break signed accounts we keep accountId as internal id used for signing.
Old accounts get a popup to add the new required field userName but accountId is
left unchanged. Newly created accounts fill accountId with the value of userName.
In the UI we only use userName.

Input validation does only check for length (5-100 chars). Not sure what
are the requirements at Revolut. Can be changes easily if anyone gets
the specs.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4453

-- Commit Summary --

  * Add support for user name for Revolut accounts

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqHeadlessApp.java (1)
    M core/src/main/java/bisq/core/app/BisqSetup.java (6)
    M core/src/main/java/bisq/core/payment/RevolutAccount.java (12)
    M core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java (58)
    M core/src/main/java/bisq/core/user/User.java (12)
    M core/src/main/resources/i18n/displayStrings.properties (11)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java (91)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (27)
    A desktop/src/main/java/bisq/desktop/main/overlays/windows/UpdateRevolutAccountWindow.java (96)
    M desktop/src/main/java/bisq/desktop/util/validation/RevolutValidator.java (9)
    M proto/src/main/proto/pb.proto (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4453.patch
https://github.com/bisq-network/bisq/pull/4453.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4453
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200830/bff78c28/attachment-0001.html>


More information about the bisq-github mailing list