[bisq-network/bisq] Add support for user name for Revolut accounts (#4453)

chimp1984 notifications at github.com
Mon Aug 31 14:49:42 UTC 2020


@chimp1984 commented on this pull request.



> +        // it has been the case before
+        String input = this.accountId == null ? "" : this.accountId;
+        return super.getAgeWitnessInputData(input.getBytes(StandardCharsets.UTF_8));
+    }
+
+    public void setUserName(@Nullable String userName) {
+        this.userName = userName;
+        // We only set accountId to userName for new accounts. Existing accounts have accountId set with email
+        // or phone nr. and we keep that to not break account signing.
+        if (accountId == null) {
+            accountId = userName;
+        }
+    }
+
+    public String getUserName() {
+        return userName != null ? userName : accountId;

I reverted accountId to empty string. Is prob. more safe. getUserName returns then also empty string by default at account creation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4453#discussion_r480182006
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200831/e4f316dd/attachment.html>


More information about the bisq-github mailing list