[bisq-network/bisq] Refactor desktop's BsqSendView 'sendbsq', share with api (#4801)

sqrrm notifications at github.com
Tue Dec 1 12:11:10 CET 2020


@sqrrm commented on this pull request.



> @@ -340,6 +342,14 @@ message GetUnusedBsqAddressReply {
      string address = 1;
 }
 
+message SendBsqRequest {
+    string address = 1;
+    double amount = 2;

This doesn't make sense to me. BSQ amounts are always going to be an integer amount of satoshis and all other coin amounts in the pb spec are `uint64`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4801#pullrequestreview-541791919
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201201/d6ea1aac/attachment.htm>


More information about the bisq-github mailing list