[bisq-network/bisq] Add api method 'getpaymentacctform' (#4819)

[Stan]

@ghubstan commented on this pull request.



> +        if (log.isDebugEnabled())
+            log.debug("Writing PaymentAccount json form for fields with accessors...");

It is intended to save unnecessary time in the logging layer, that's why I do this.  In this case, the performance savings is trivially small because the logged message is just a string literal.

For things like 
```
    log.debug("{} blah {} blah blah {} ... {} .. {}", 
       someCheapCalculation1, 
       someCheapCalculation2, 
       someExpensiveCalculation3, 
       literal4, 
       someReallyExpensiveCalculation5);
```

the cheap and expensive calculations are performed even if the log level is ERROR.

If wrapped by `if (log.isDebugEnabled())`, the calculations are skipped.  But I don't like the additional lines either.  And in this case it buys nothing, I'll fix it.

I think there are situations where this is a good thing to do, but this isn't one of them.   There are other places I'll fix for the same reason.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4819#discussion_r533520412
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201201/f2e3c1bf/attachment.htm>