[bisq-network/bisq] Add tx fee rate api methods: gettxfeerate, settxfeerate, unsettxfeerate (#4858)

[Stan]

@ghubstan commented on this pull request.



> +        String customTxFeeRate = txFeeRateInfo.getCustomTxFeeRate() < 0
+                ? formatTxFeeRate(txFeeRateInfo.getCustomTxFeeRate())
+                : null;

To clear this up, I should probably add a `boolean useCustomWithdrawalTxFee` field to `TxFeeRateInfo`.  This would be set from the `Preference#useCustomWithdrawalTxFee` value.     (Remember that `Preferences` is not visible to the CLI, and these `*Info` proto wrappers are for passing the minimum data needed from server to CLI.)

This confusion is caused by not having that field.  When `txFeeRateInfo.getCustomTxFeeRate() == -1`, the custom tx fee rate preference is ignored in the CLI.  In core, it means the preference.useCustomWithdrawalTxFee == false.

In pseudo English, it means

```
String customTxFeeRate = (if are we using the fee service's tx fee rate)
                ? (format the custom tx fee rate)
                : null;

```

Adding a `boolean useCustomWithdrawalTxFee` field to `TxFeeRateInfo` would fix this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4858#discussion_r533576481
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201201/9bdcfd10/attachment-0001.htm>