[bisq-network/bisq] Replace use of Collections to FXCollections in desktop. (#4875)

deusmax notifications at github.com
Wed Dec 2 18:02:25 CET 2020


Replace use of java library java.util.Collections with
javafx.collections.FXCollections instead.
Bisq issue#4388.

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Replace use of java.util.Collections, except for a few places that use Collections.singleton and Collections.nCopies which do not have direct replacements in FXCollections.
Run code and did not notice any issues.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4875

-- Commit Summary --

  * Replace use of Collections to FXCollections in desktop.

-- File Changes --

    M desktop/src/main/java/bisq/desktop/components/indicator/skin/StaticProgressIndicatorSkin.java (18)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (5)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsViewModel.java (14)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java (5)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (6)
    M desktop/src/main/java/bisq/desktop/util/AxisInlierUtils.java (4)
    M desktop/src/test/java/bisq/desktop/main/funds/transactions/DisplayedTransactionsTest.java (4)
    M desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java (53)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4875.patch
https://github.com/bisq-network/bisq/pull/4875.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4875
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201202/1af3a71d/attachment.htm>


More information about the bisq-github mailing list