[bisq-network/bisq] Avoid that buyer switches back to trade step 2 at startup after payment confirmed (#4885)

[chimp1984]

Fixes https://github.com/bisq-network/bisq/issues/4864

When seller if offline we resend the CounterCurrencyTransferStartedMessage at startup.
That caused the trade state set to BUYER_SENT_FIAT_PAYMENT_INITIATED_MSG and then after
the msg was stored in mailbox to BUYER_STORED_IN_MAILBOX_FIAT_PAYMENT_INITIATED_MSG.
Those 2 msg trigger diff. UI states which led to the UI glitch that the UI moved to
step 2 and then to step 3 which was correct but confusing to the user.

Now we only apply BUYER_SENT_FIAT_PAYMENT_INITIATED_MSG is trade state ordinal is
smaller avoiding that UI glitch.

This is not a critical bug fix so open to maintainers to add it to 1.5.1. But I think its also very low risk and easy to review and test.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4885

-- Commit Summary --

  * Fixes https://github.com/bisq-network/bisq/issues/4864

-- File Changes --

    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4885.patch
https://github.com/bisq-network/bisq/pull/4885.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4885
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201203/f4da9155/attachment.htm>