[bisq-network/bisq] Offer Book chart outlier filter improved. (#4892)

deusmax notifications at github.com
Thu Dec 3 21:44:41 CET 2020


Outlier data filter used for the Market Offer Book chart, now accounts
for the switching display position of Buy, Sell data depending on
currency type (Crypto or Fiat).

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes #4871  

Some of the Market Offers have values far from the main trading body (outliers). Including these points in a chart destroys any significant and useful information presented in the graph. An outlier filter, applied during the production of these charts, is used to remove such points. 

The implementation of this filter did not take into account the chart differences between fiat and crypto currencies. The one in this PR does.
The recently increasing Fiat value of BTC, coupled with extreme outlier values, has exposed the limitations. This PR provides a filter that gives better results and should be much more stable. 

See issue #4871 for before & after screenshots.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4892

-- Commit Summary --

  * Offer Book chart outlier filter improved.

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (96)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4892.patch
https://github.com/bisq-network/bisq/pull/4892.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4892
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201203/0ca8c0b1/attachment.htm>


More information about the bisq-github mailing list