[bisq-network/bisq] Avoid case of multi trades with same offer (#4889)

[sqrrm]

@sqrrm approved this pull request.

utACK

>                          MakerRemovesOpenOffer.class,
+                        BuyerProcessDelayedPayoutTxSignatureRequest.class,

Could this be abused by sending a bad request, causing offers to be removed but guaranteed failed trade?

>          }
         TradeProtocol tradeProtocol = TradeProtocolFactory.getNewTradeProtocol(trade);
-        tradeProtocolByTradeId.put(trade.getId(), tradeProtocol);
+        TradeProtocol prev = tradeProtocolByTradeId.put(trade.getUid(), tradeProtocol);
+        if (prev != null) {
+            log.error("We had already an entry with uid {}", trade.getUid());

How would this happen? Collision of randomUUID?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4889#pullrequestreview-544480774
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201203/5432d0d9/attachment.htm>