[bisq-network/bisq] Add optional txFeeRate parameter to api sendbsq (#4900)
Stan
notifications at github.com
Fri Dec 4 21:22:12 CET 2020
If present in the api's `sendbsq` command, the parameter will override the fee service and custom fee rate setting for the BSQ transaction.
Also changed the `sendbsq` grpc return type to a lightweight TX proto wrapper.
Besides some small refactoring in the CLI, all the changes are adjustments for this new `sendbsq` parameter and its new grpc return value.
This is the 3rd in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4884.
PR https://github.com/bisq-network/bisq/pull/4896 should be reviewed before this one.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4900
-- Commit Summary --
* Refactor: move getDust(Transaction transaction)
* Refactor BtcWalletService to let api override fee rates
* Merge branch 'master' into 02-refactor-completePreparedSendBsqTx
* Add optional txFeeRate parameter to api sendbsq
-- File Changes --
M apitest/src/test/java/bisq/apitest/method/MethodTest.java (27)
M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (2)
M cli/src/main/java/bisq/cli/CliMain.java (57)
M core/src/main/java/bisq/core/api/CoreApi.java (7)
M core/src/main/java/bisq/core/api/CoreWalletsService.java (18)
A core/src/main/java/bisq/core/api/model/TxInfo.java (84)
M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (5)
M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (40)
M core/src/main/java/bisq/core/btc/wallet/WalletService.java (14)
M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (41)
M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (4)
M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (20)
M proto/src/main/proto/grpc.proto (27)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4900.patch
https://github.com/bisq-network/bisq/pull/4900.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4900
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201204/62f749da/attachment.htm>
More information about the bisq-github
mailing list