[bisq-network/bisq] Improve getBlocks request handling (#4851)

sqrrm notifications at github.com
Fri Dec 4 23:05:25 CET 2020


@sqrrm commented on this pull request.



> @@ -168,31 +167,36 @@ public void onFailure(@NotNull Throwable throwable) {
     @Override
     public void onMessage(NetworkEnvelope networkEnvelope, Connection connection) {
         if (networkEnvelope instanceof GetBlocksResponse) {

That's a good point. Might be cleaner to make a `handleGetBlocksResponse(GetBlocksResponse r)` and other respective dispatch handlers like is done in the trade protocol for these cases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4851#discussion_r536410759
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201204/156bfeb5/attachment.htm>


More information about the bisq-github mailing list