[bisq-network/bisq] Add new api method 'sendbtc' (#4901)

Stan notifications at github.com
Sat Dec 5 20:01:08 CET 2020


Takes an address, amount, and optional txfeerate param, returns a lightweight `TxInfo` proto.

Also overloaded two `BtcWalletService` methods to allow sendbtc to pass in the tx fee rate -- overriding the fee service and custom fee rate setting.


This is the 4th in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4884.
PR https://github.com/bisq-network/bisq/pull/4900 should be reviewed before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4901

-- Commit Summary --

  * Refactor: move getDust(Transaction transaction)
  * Refactor BtcWalletService to let api override fee rates
  * Merge branch 'master' into 02-refactor-completePreparedSendBsqTx
  * Add optional txFeeRate parameter to api sendbsq
  * Add new api method 'sendbtc'

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (53)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (41)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (1)
    M cli/src/main/java/bisq/cli/CliMain.java (86)
    M core/src/main/java/bisq/core/api/CoreApi.java (17)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (98)
    A core/src/main/java/bisq/core/api/model/TxInfo.java (84)
    M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (5)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (59)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (14)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (87)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (20)
    M proto/src/main/proto/grpc.proto (39)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4901.patch
https://github.com/bisq-network/bisq/pull/4901.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4901
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201205/a42ab1a4/attachment.htm>


More information about the bisq-github mailing list