[bisq-network/bisq] Refactor BtcWalletService to let api override fee rates (#4896)
sqrrm
notifications at github.com
Mon Dec 7 14:46:16 CET 2020
@sqrrm commented on this pull request.
I think the changes look ok.
Needs review from @ManfredKarrer
> - Transaction txWithBtcFee = btcWalletService.completePreparedBsqTx(preparedTx, true, opReturnData);
+ Transaction txWithBtcFee = btcWalletService.completePreparedBsqTx(preparedTx, opReturnData);
Unrelated to the changes in this PR, but why are we using custom fee for a DAO operation? This is the lockup tx, should probably use the fee from feeService.
> @@ -487,8 +499,6 @@ public Transaction completePreparedBsqTx(Transaction preparedBsqTx,
int sigSizePerInput = 106;
// typical size for a tx with 2 inputs
int txVsizeWithUnsignedInputs = 203;
- // If useCustomTxFee we allow overriding the estimated fee from preferences
- Coin txFeePerVbyte = useCustomTxFee ? getTxFeeForWithdrawalPerVbyte() : feeService.getTxFeePerVbyte();
Looks like custom fee was always used when calling this method anyway.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4896#pullrequestreview-546158375
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201207/d22e0771/attachment.htm>
More information about the bisq-github
mailing list