[bisq-network/bisq] Refactor BtcWalletService to let api override fee rates (#4896)

Stan notifications at github.com
Mon Dec 7 15:27:29 CET 2020


@ghubstan commented on this pull request.



> @@ -487,8 +499,6 @@ public Transaction completePreparedBsqTx(Transaction preparedBsqTx,
         int sigSizePerInput = 106;
         // typical size for a tx with 2 inputs
         int txVsizeWithUnsignedInputs = 203;
-        // If useCustomTxFee we allow overriding the estimated fee from preferences
-        Coin txFeePerVbyte = useCustomTxFee ? getTxFeeForWithdrawalPerVbyte() : feeService.getTxFeePerVbyte();

Yes, unless the `preferences.isUseCustomWithdrawalTxFee()` was false.
Only if the `useCustomTxFee` param was `false` (it never was), would the fee service would be used. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4896#discussion_r537547898
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201207/dfaa0977/attachment.htm>


More information about the bisq-github mailing list