[bisq-network/bisq] Support tx memo field for btc withdrawals from api (#4925)

Stan notifications at github.com
Wed Dec 9 20:57:11 CET 2020


- Added optional memo parameter to the api's `sendbtc` and `withdrawfunds` commands.

- Removed the `@Nullable` annotation was removed because protobuf does not support null.  The implementation will pass null if parameter string is empty.

- Visibility in two `CoreWalletService` wallet check methods were changed from private to pkg protected so the `CoreTradeService` could use them.
  
- Adjusted affected tests.  (Asserting the memo field was set on a transaction cannot be checked from `apitest` yet.)

This is the 5th in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4884.
PR https://github.com/bisq-network/bisq/pull/4922 should be reviewed before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4925

-- Commit Summary --

  * Refactor BtcWalletService to let api override fee rates
  * Merge branch 'master' into 02-refactor-completePreparedSendBsqTx
  * Add optional txFeeRate parameter to api sendbsq
  * Merge branch 'master' into 03-add-txFeeRate-param
  * Add new api method 'sendbtc' and test
  * Merge branch 'master' into 04-add-sendbtc-impl
  * Support tx memo field for btc withdrawals from api

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (67)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (37)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (1)
    M cli/src/main/java/bisq/cli/CliMain.java (102)
    M core/src/main/java/bisq/core/api/CoreApi.java (22)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (25)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (106)
    A core/src/main/java/bisq/core/api/model/TxInfo.java (84)
    M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (5)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (47)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (6)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (87)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (4)
    M proto/src/main/proto/grpc.proto (41)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4925.patch
https://github.com/bisq-network/bisq/pull/4925.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4925
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201209/d8d8411d/attachment.htm>


More information about the bisq-github mailing list