[bisq-network/bisq] Append nullable withdrawalTxId field to Trade proto message (#4937)

[Stan]

The `withdrawalTxId` field will be set in `TradeManager#onWithdrawRequest` after successful trade completion and withdrawal of funds.

Persisting `withdrawalTxId` will allow the api and ui to find the `withdrawalTxId` for a completed trade after the seller withdraws funds to an external wallet.  In turn, the withdrawal tx's memo field will be accessible in a new api `getTransaction(id)` api method (todo) .

Changed:

- Appended field `string withdrawal_tx_id = 40` to pb.proto's Trade message.

- Added nullable `String withdrawalTxId` to Trade entity class.

- Added `trade.setWithdrawalTxId(transaction.getTxId().toString())` in `TradeManager#onWithdrawRequest`'s callback.


This is the 7th in a chain of PRs beginning with https://github.com/bisq-network/bisq/pull/4884.
PR https://github.com/bisq-network/bisq/pull/4936 should be reviewed before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4937

-- Commit Summary --

  * Refactor BtcWalletService to let api override fee rates
  * Merge branch 'master' into 02-refactor-completePreparedSendBsqTx
  * Add optional txFeeRate parameter to api sendbsq
  * Merge branch 'master' into 03-add-txFeeRate-param
  * Add new api method 'sendbtc' and test
  * Merge branch 'master' into 04-add-sendbtc-impl
  * Support tx memo field for btc withdrawals from api
  * Remove unused imports
  * Merge branch 'master' into 05-use-memo-tx-field
  * Use Bisq's UserThread.executor in gRPC server
  * Append nullable withdrawalTxId field to Trade proto message

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (67)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (37)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (1)
    M cli/src/main/java/bisq/cli/CliMain.java (102)
    M core/src/main/java/bisq/core/api/CoreApi.java (22)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (25)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (106)
    A core/src/main/java/bisq/core/api/model/TxInfo.java (84)
    M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (5)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (47)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
    M core/src/main/java/bisq/core/trade/Trade.java (7)
    M core/src/main/java/bisq/core/trade/TradeManager.java (1)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (3)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (87)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (4)
    M proto/src/main/proto/grpc.proto (41)
    M proto/src/main/proto/pb.proto (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4937.patch
https://github.com/bisq-network/bisq/pull/4937.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4937
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201212/8c51b7a0/attachment-0001.htm>