[bisq-network/bisq] Upgrade JavaFX to v15 (#4242)
Christoph Atteneder
notifications at github.com
Mon Dec 14 11:55:44 CET 2020
@ripcurlx commented on this pull request.
> + " libdecora_sse.dylib" +
+ " libprism_sw.dylib" +
+ " org/bridj/lib/darwin_universal/libbridj.dylib" +
+ " META-INF/native/libio_grpc_netty_shaded_netty_tcnative_osx_x86_64.jnilib" +
+ " lib/x86_64/darwin/libscrypt.dylib" +
+ " com/github/sarxos/webcam/ds/buildin/lib/darwin_universal/libOpenIMAJGrabber.dylib"
+ )
+
+ // Extract dylibss for signing
+ executeCmd("cd ${tempDylibFolderPath} &&" +
+ " jar xf ${fatJarFolderPath}/${mainJarName}" +
+ dylibsToSign)
+
+ // Sign them
+ executeCmd("cd ${tempDylibFolderPath} &&" +
+ " codesign -vvv --options runtime --deep --force --sign \"Developer ID Application: Christoph Atteneder (WQT93T6D6C)\"" +
I think it would be good to use an environment var or similar than to hard code my developer id in there. Just in case someone takes over the release builds.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4242#pullrequestreview-551255459
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201214/8020f0ec/attachment.htm>
More information about the bisq-github
mailing list