[bisq-network/bisq] Cache results of isFiatCurrency and isCryptoCurrency (#4955)

Steven Barclay notifications at github.com
Tue Dec 15 10:44:22 CET 2020


I'm a little surprised there's much speedup, since the methods `CurrencyUtil.get[Crypto|Fiat]Currency` and `Currency.getInstance` are already memoised and the other steps in `isCryptoCurrency` and `isFiatCurrency` appear to be extremely cheap. Do you know know exactly where the bottleneck in the old version lies? I'm wondering if it could be in the `catch (Throwable t) {...}` path of `isFiatCurrency`, since it looks like the first three memoising methods don't cache their result in the case of an exception.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4955#issuecomment-745173620
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201215/7f65b342/attachment.htm>


More information about the bisq-github mailing list