[bisq-network/bisq] Sign single account (#4957)

sqrrm notifications at github.com
Tue Dec 15 16:21:21 CET 2020


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

This a proposed solution to https://github.com/bisq-network/growth/issues/212

The user to get signed copies the account data and sends it over whichever channel, keybase for example. With this change the arbitrator can sign this account.

Step 1, user copies account data (ctrl+c to copy AccountAgeWitness and PubKey to clipboard)
![image](https://user-images.githubusercontent.com/23560607/102233437-8dfa5b00-3ef0-11eb-8959-e9ee05c4ec13.png)

Step 2, arbitrator imports data (under accounts view, open signing tab with ctrl+i, in signing tab, open specific account signing window with ctrl+p)
![image](https://user-images.githubusercontent.com/23560607/102233347-791dc780-3ef0-11eb-8a56-da22103961a2.png)

Step 3, arbitrator signs with their private key (this could be helpful for devs that want to test signed accounts as well)
![image](https://user-images.githubusercontent.com/23560607/102233610-bf732680-3ef0-11eb-93f7-ae7fe67ab6c1.png)

Step 4, done
![image](https://user-images.githubusercontent.com/23560607/102233674-cf8b0600-3ef0-11eb-80a2-a3cd23cd15a7.png)

I know this is very pretty, but please don't ask me to implement all the UI stuff due to this flash feature.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4957

-- Commit Summary --

  * Copy account data to clipboard
  * Sign imported AccountAgeWitness,PubKey

-- File Changes --

    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (27)
    M core/src/main/resources/i18n/displayStrings.properties (5)
    M desktop/src/main/java/bisq/desktop/main/account/content/PaymentAccountsView.java (5)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (10)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SignSpecificWitnessWindow.java (120)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4957.patch
https://github.com/bisq-network/bisq/pull/4957.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4957
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201215/fcec2bbd/attachment.htm>


More information about the bisq-github mailing list