[bisq-network/bisq] Cache results of isFiatCurrency and isCryptoCurrency (#4955)

chimp1984 notifications at github.com
Tue Dec 15 17:30:39 CET 2020


> Yes, I think I recall the methods being a significant hotspot, when profiling the UI a while ago, so even small absolute speedups are probably worthwhile. The updated changes in the PR look fine to me.
> 
> utACK

Yes, they are relatively easy and low risk, thats why I started on that beside other more complex ones like in the DAO domain...
A big part are item renderers not caching data but using viewModels as in offerBook. Will work on that as well but thats much more effort...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4955#issuecomment-745406254
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201215/c02d44c3/attachment.htm>


More information about the bisq-github mailing list