[bisq-network/bisq] Add new api method 'sendbtc' and test (#4922)

Stan notifications at github.com
Tue Dec 15 17:58:41 CET 2020


@ghubstan commented on this pull request.



> +
+        log.debug("{} Alice's BTC Balances:\n{}",
+                testName(testInfo),
+                formatBtcBalanceInfoTbl(alicesBalances));
+        bisq.core.api.model.BtcBalanceInfo alicesExpectedBalances =
+                bisq.core.api.model.BtcBalanceInfo.valueOf(700000000,
+                        0,
+                        700000000,
+                        0);
+        verifyBtcBalances(alicesExpectedBalances, alicesBalances);
+
+        BtcBalanceInfo bobsBalances = getBtcBalances(bobdaemon);
+        log.debug("{} Bob's BTC Balances:\n{}",
+                testName(testInfo),
+                formatBtcBalanceInfoTbl(bobsBalances));
+        // We cannot (?) predict the exact tx size and calculate how much in tx fees were

I think so too, but the `sendbtc` tx size randomly varies between two distinct values (219 bytes or 220 bytes) from test run to test run, hence the available balance range [1549978000, 1549978100].
Is that a bug?  
Should I be more specific about this in that test case's comment?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4922#discussion_r543518797
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201215/c1dbe88a/attachment.htm>


More information about the bisq-github mailing list