[bisq-network/bisq] Append nullable withdrawalTxId field to Trade proto message (#4937)

[Stan]

@ghubstan commented on this pull request.



> @@ -317,6 +317,10 @@ public boolean isArbitrated() {
     @Getter
     @Setter
     private String payoutTxId;
+    @Nullable
+    @Getter
+    @Setter
+    private String withdrawalTxId;

Your call.  I'll [adjust the next PR](https://github.com/bisq-network/bisq/pull/4948) if you don't want it.

I thought it was an inexpensive way to associate the withdrawal tx to the trade.  To me, setting a memo on a trade withdrawal tx isn't very useful if you don't have an easy way to find that tx.

By the way, this tx is associated (in my head) when I optionally withdraw (seller) trade funds to an external wallet, as the final step of the trade protocol.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4937#discussion_r543526197
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201215/db064119/attachment.htm>