[bisq-network/bisq] Append nullable withdrawalTxId field to Trade proto message (#4937)

[Stan]

@ghubstan commented on this pull request.



> @@ -317,6 +317,10 @@ public boolean isArbitrated() {
     @Getter
     @Setter
     private String payoutTxId;
+    @Nullable
+    @Getter
+    @Setter
+    private String withdrawalTxId;

I did not think this would make much sense to anyone until they've seen the next [PR](https://github.com/bisq-network/bisq/pull/4948), and I explain my reason a bit more/better.


Here is Bob's `gettrade` CLI output after withdrawing funds to an external wallet:

```
ID       My Role             Price in USD for 1 BTC  Amount(BTC)  Tx Fee(BTC)  Taker Fee(BTC)  Deposit Published  Deposit Confirmed  Fiat Sent  Fiat Received  Payout Published  Withdrawn  Withdrawal TX ID  
5006844  BTC buyer as taker             19,410.6419   0.12500000   0.00012932      0.00037500  YES                YES                YES        YES            YES               YES        0128e08406542a15ecc27234afa9ca9f4112f74d105459d18b4cfde93028291b
``` 

If `Withdrawn` = NO, the `Withdrawal TX ID` column would not appear in the console output.

Here is Bob's `gettransaction` CLI output:

```
Tx ID                                                             Is Confirmed  Tx Inputs (BTC)  Tx Outputs (BTC)  Tx Fee (BTC)  Tx Size (Bytes)  Memo  
0128e08406542a15ecc27234afa9ca9f4112f74d105459d18b4cfde93028291b           YES       0.14375000        0.14368229    0.00006771              193  Bob's trade withdrawal
```

Likewise, if there is no memo, the `Memo` column is not displayed.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4937#discussion_r543747251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201215/d85fc844/attachment.htm>