[bisq-network/bisq] Improve offer publishing (#4950)

[chimp1984]

@chimp1984 commented on this pull request.



>          }
+
+        OpenOffer openOffer = list.remove(0);
+        if (!openOffers.contains(openOffer) || openOffer.isDeactivated()) {

No it is correct, we call our recursive method with the list where we have removed that offer. But the following lines neede to be in a else branch.
I made a PR where I invert the if check and add a comment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4950#discussion_r544295572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201216/5fd6207b/attachment.htm>