[bisq-network/bisq] Privacy improvements for manual payout (#4899)
chimp1984
notifications at github.com
Wed Dec 16 18:42:01 CET 2020
@chimp1984 approved this pull request.
ACK
Tested now and worked all! Great tool!
Small nit with catching invalid inputs at parseCoin...
>
- TxBroadcaster.Callback callback = new TxBroadcaster.Callback() {
- @Override
- public void onSuccess(@Nullable Transaction result) {
- log.error("onSuccess");
- UserThread.execute(() -> {
- String txId = result != null ? result.getTxId().toString() : "null";
- new Popup().information("Transaction successful published. Transaction ID: " + txId).show();
- });
- }
+ private void calculateTxFee() {
+ if (buyerPayoutAmount.getText().length() > 0 &&
+ sellerPayoutAmount.getText().length() > 0 &&
+ amountInMultisig.getText().length() > 0) {
+ Coin txFeeValue = Coin.parseCoin(amountInMultisig.getText())
Coin.parseCoin can throw exceptions if input format is not as expected. Best to add a try catch...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4899#pullrequestreview-553930349
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201216/8561d467/attachment.htm>
More information about the bisq-github
mailing list