[bisq-network/bisq] Upgrade JavaFX to v15 (#4242)

[Christoph Atteneder]

@ripcurlx commented on this pull request.



> +                        macOpts +
+                        " --type app-image")
+
+                // macOS step 3: Sign app (hardended runtime)
+                File bisqAppImageFullPath = new File(binariesFolderPath, "Bisq.app")
+                executeCmd("codesign" +
+                        " --sign \"${envVariableSigningID}\"" +
+                        " --options runtime" +
+                        " --entitlements macos.entitlements" +
+                        " --force" +
+                        " --verbose" +
+                        "${bisqAppImageFullPath}/Contents/runtime/Contents/MacOS/libjli.dylib")
+                executeCmd("codesign" +
+                        " --sign \"${envVariableSigningID}\"" +
+                        " --options runtime" +
+                        " --entitlements macos.entitlements" +

I think you missed to add the `macos.entitlements` file to the build.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4242#pullrequestreview-553991406
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201216/715e0e29/attachment.htm>