[bisq-network/bisq] Translate checkArgument messages (#4978)

Jakub Loucký notifications at github.com
Sat Dec 19 23:46:41 CET 2020


Fixes #2619

Messages in some checkArgument calls are replaced with translatable strings.

There are many more instances, incl. ones in calls of similar functions (notEmpty, notBlank, notNull). However, most seem to be unreachable by the users; the GUI prevents the conditions from ever happening. Many messages are not even intended to be seen by users; they include things like private method names and local variable names.

In fact, I wasn't able to reproduce even some of those few messages that are updated by this PR.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4978

-- Commit Summary --

  * Translate checkArgument messages

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (33)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (11)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/reputation/MyReputation.java (3)
    M core/src/main/resources/i18n/displayStrings.properties (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4978.patch
https://github.com/bisq-network/bisq/pull/4978.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4978
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201219/00435e73/attachment.htm>


More information about the bisq-github mailing list