[bisq-network/bisq] Append nullable withdrawalTxId field to Trade proto message (#4937)

[sqrrm]

@sqrrm commented on this pull request.



> @@ -317,6 +317,10 @@ public boolean isArbitrated() {
     @Getter
     @Setter
     private String payoutTxId;
+    @Nullable
+    @Getter
+    @Setter
+    private String withdrawalTxId;

Thought so to begin with as well. Now I'm thinking it makes more sense to associate the withdrawal with the trade as it's a way to know where the bitcoin went. Considering we have the feature to fund trades externally and withdraw directly it seems this withdrawal is directly related to this trade.

I now have an utACK for this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4937#discussion_r546734605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201221/9da55920/attachment.htm>