[bisq-network/bisq] Cleanup trade wallet code (#4997)

Stan notifications at github.com
Thu Dec 24 16:06:06 CET 2020


@ghubstan commented on this pull request.



> @@ -27,12 +27,16 @@
 
 import javax.annotation.concurrent.Immutable;
 
+/**
+ * Holds the relevant data for the connected output for a tx input.
+ * ParentTransaction means here the spending tx, the tx of the output not the parentTransaction of the input itself.
+ * Also index refers to the index of the spending output
+ */

I would reformat the method javadoc with some minor grammar changes:
```
    /**
     * Holds the relevant data for the connected output for a tx input.
     * @param index  the index of the parentTransaction
     * @param parentTransaction  the spending output tx, not the parent tx of the input
     * @param value  the number of satoshis being spent
     */

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4997#pullrequestreview-558629920
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201224/7b49f6f0/attachment.htm>


More information about the bisq-github mailing list