[bisq-network/bisq] Move BSQ price in USD at first row (#4988)

Stan notifications at github.com
Thu Dec 24 16:29:59 CET 2020


@ghubstan commented on this pull request.

I would give this a `Tested ACK` right now, but will delay until you have seen what happens if I click the `DAO` menu item why the initial sync is in progress:

```
Dec-24 13:20:17.737 [JavaFX Application Thread] INFO  b.c.d.n.p.BlockParser: Parsing 0 transactions at block height 658790 took 0 ms 
Dec-24 13:20:17.843 [JavaFX Application Thread] INFO  b.c.d.n.p.BlockParser: Parsing 5 transactions at block height 658791 took 0 ms 
Dec-24 13:20:17.944 [JavaFX Application Thread] INFO  b.c.d.n.p.BlockParser: Parsing 1 transactions at block height 658792 took 0 ms 
Dec-24 13:20:17.974 [NetworkNode:SendMessage-to-n55uir3nbux3oerkmldrqiua3tvxedtcqggr5k4rprzvttqk3xawdhid.onion:9999] INFO  b.n.p.n.NetworkNode: Socket creation to peersNodeAddress n55uir3nbux3oerkmldrqiua3tvxedtcqggr5k4rprzvttqk3xawdhid.onion:9999 took 15216 ms 
Dec-24 13:20:18.391 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
Dec-24 13:20:18.391 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableMessage= null 
Dec-24 13:20:18.391 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableClass= class java.lang.NullPointerException 
Dec-24 13:20:18.393 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.NullPointerException
	at bisq.desktop.components.JFXTextFieldSkinBisqStyle.updateTextPos(JFXTextFieldSkinBisqStyle.java:95)
	at bisq.desktop.components.JFXTextFieldSkinBisqStyle.layoutChildren(JFXTextFieldSkinBisqStyle.java:79)
	at javafx.scene.control.Control.layoutChildren(Control.java:601)
	at javafx.scene.Parent.layout(Parent.java:1204)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Parent.layout(Parent.java:1211)
	at javafx.scene.Scene.doLayoutPass(Scene.java:576)
	at javafx.scene.Scene$ScenePulseListener.pulse(Scene.java:2482)
	at com.sun.javafx.tk.Toolkit.lambda$runPulse$2(Toolkit.java:412)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:389)
	at com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:411)
	at com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:438)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:519)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:499)
	at com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:492)
	at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:320)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
	at java.base/java.lang.Thread.run(Thread.java:835)
 
Dec-24 13:20:18.395 [JavaFX Application Thread] INFO  b.n.p.p.PeerManager: Num of latestLivePeers=9 
Dec-24 13:20:18.414 [JavaFX Application Thread] INFO  b.c.d.n.p.BlockParser: Parsing 0 transactions at block height 658793 took 0 ms 
Dec-24 13:20:18.577 [JavaFX Application Thread] INFO  b.c.d.n.p.BlockParser: Parsing 1 transactions at block height 658794 took 0 ms 
Dec-24 13:20:18.702 [JavaFX Application Thread] INFO  b.c.d.n.p.BlockParser: Parsing 0 transactions at block height 658795 took 0 ms 

```




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4988#pullrequestreview-558663844
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201224/1daa5d74/attachment.htm>


More information about the bisq-github mailing list