[bisq-network/bisq] Deactivate open offer if trigger price is reached (#5001)

Stan notifications at github.com
Fri Dec 25 17:35:15 CET 2020


@ghubstan commented on this pull request.

I do see the offer disabling trigger price in the edit offer view, but can't edit it.  Is that too difficult to do?  Or do you see that feature not really necessary?

Also, I can't see the disabling trigger price in the published offer views (below).  Squeezing it into the list view might not be feasible, but adding it to the other two might be trivial.

Confirm Offer View..
![where-is-trigger-price](https://user-images.githubusercontent.com/36207203/103138797-cc440700-46b4-11eb-9826-c160b9556a5f.png)

Published Offer List View...
![where-is-trigger-price-in-offer-list](https://user-images.githubusercontent.com/36207203/103138800-ce0dca80-46b4-11eb-9291-41d6e8ce8545.png)

Published Offer Detail View...
![where-is-trigger-price-in-published-offer-detail](https://user-images.githubusercontent.com/36207203/103138806-d49c4200-46b4-11eb-9576-103e56219771.png)


> @@ -0,0 +1,151 @@
+/*

I instinctively need to ask if  `PriceUtil` could be moved to core.  I see dependencies on ChatView.log and ui validators, but much of the util logic could be made available to the api.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5001#pullrequestreview-558825938
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201225/1c750921/attachment-0001.htm>


More information about the bisq-github mailing list