[bisq-network/bisq] Deactivate open offer if trigger price is reached (#5001)

chimp1984 notifications at github.com
Fri Dec 25 18:27:10 CET 2020


I was in the process to add a field there but as it only gets the offer passed but not the openOffer I was not sure... But probably its better to add it as well.
The triggerPrice is a field in openOffer not in Offer. Offer will be a part of trade and I think trigger price is a local setting of the user not a part of the mutual data which will be shared with the peer.

There is a trigger price column in openOffersView but it is hidden at default stage width as there is not enough space. If you scale larger it will get added. Similar we use in closed trades, there are a few detail columns only shown when width is larger. I am aware that many users might miss those hidden features, but have not found a good solution yet for it...
Maybe some icon on the table indicating that the table changes on resize, but as that is not a common UI feature I fear the icon will be just confusing...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5001#issuecomment-751274095
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201225/97a2055c/attachment.htm>


More information about the bisq-github mailing list