[bisq-network/bisq] Remove awt dependencies (#5008)
James Cox
notifications at github.com
Sun Dec 27 04:17:37 CET 2020
Related to #4940
Replace usage of awt classes wherever possible with the JavaFX equivalents.
- Do not use system tray.
- Remove usages of `java.awt.Desktop` for opening URIs. Use `openSystemSpecific()` instead.
- Remove usages of `java.awt.GraphicsEnvironment`. Use `javafx.stage.Screen` instead.
- Detect MacOS retina display by `Screen.getPrimary().getOutputScaleX() > 1.5;`
----
To open a URI we take a convoluted path from `GUIUtil.openWebPage` (desktop) to `Utilities.openURI` (common) to `DesktopUtil.browse` (common). What do you think about simplifying this by moving DesktopUtil from common to desktop?
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5008
-- Commit Summary --
* remove awt dependencies
-- File Changes --
M common/src/main/java/bisq/common/util/DesktopUtil.java (106)
M common/src/main/java/bisq/common/util/Utilities.java (35)
M desktop/src/main/java/bisq/desktop/app/BisqApp.java (20)
D desktop/src/main/java/bisq/desktop/app/SystemTray.java (162)
M desktop/src/main/java/bisq/desktop/util/ImageUtil.java (12)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5008.patch
https://github.com/bisq-network/bisq/pull/5008.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5008
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201226/6654ac39/attachment.htm>
More information about the bisq-github
mailing list