[bisq-network/bisq] Fix layout of button and checkbox in Receive funds (#5018)
Jakub Loucký
notifications at github.com
Tue Dec 29 01:41:54 CET 2020
Fixes #5017
The checkbox "_Native segwit format_" had a fixed position in a GridPane cell that is shared with the _Generate_ button. Now the two elements are placed in a HBox which will handle the varying width of the button gracefully.
I have repurposed a set of methods `addButtonCheckBox` that are not used anywhere in the project. I decided to change a few details in the method (added `CENTER_LEFT` alignment; leaving column index at default); these seem to be sensible defaults. Adding an additional method argument seemed unnecessary at this point.
## Before:
![button + checkbox official CZ](https://user-images.githubusercontent.com/16313562/103250863-57075900-4976-11eb-8b0f-7d5c8de9b334.png)
## After:
![image](https://user-images.githubusercontent.com/16313562/103250881-71d9cd80-4976-11eb-8069-52f61f4f3563.png)
![image](https://user-images.githubusercontent.com/16313562/103250899-8a49e800-4976-11eb-8070-40cbf2b3fcfe.png)
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5018
-- Commit Summary --
* Fix layout of button and checkbox in Receive funds
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.java (19)
M desktop/src/main/java/bisq/desktop/util/FormBuilder.java (18)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5018.patch
https://github.com/bisq-network/bisq/pull/5018.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5018
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201228/0bc47202/attachment-0001.htm>
More information about the bisq-github
mailing list