[bisq-network/bisq] Adjust lombok annotations to reduce build warnings (#5021)

[Stan]

This change fixes the underlying problems behind five compiler warnings:  `Generating equals/hashCode implementation but without a call to superclass`.

Some core classes use `@Value` and `@Data` annotations where not necessary, for example, where `equals`, `hashCode`, and `toString` methods, and `final` class and field modifiers are defined by a developer.

>From lombok classes and documents for the shortcut annotations [`@Value`](https://projectlombok.org/features/Value)  and [`@Data`]( https://projectlombok.org/features/Data), we find some implicit annotations applied by these shortcuts are not needed.  Adjustments are described below.

- `Tx` Replace `@Value` with `@Getter`.

- `TxOutput`  Replace `@Data` with `@Getter` and `@Setter`.

- `ChangeParamProposal`  Replace `@Value` with `@Getter`.

- `GetInventoryRequest`, `GetInventoryResponse`  An `@EqualsAndHashCode(callSuper = false) `is added to supress build warnings.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5021

-- Commit Summary --

  * Adjust lombok annotations to reduce build warnings

-- File Changes --

    M core/src/main/java/bisq/core/dao/state/model/blockchain/Tx.java (4)
    M core/src/main/java/bisq/core/dao/state/model/blockchain/TxOutput.java (6)
    M core/src/main/java/bisq/core/dao/state/model/governance/ChangeParamProposal.java (6)
    M core/src/main/java/bisq/core/network/p2p/inventory/messages/GetInventoryRequest.java (2)
    M core/src/main/java/bisq/core/network/p2p/inventory/messages/GetInventoryResponse.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5021.patch
https://github.com/bisq-network/bisq/pull/5021.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5021
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201229/76702a07/attachment-0001.htm>