[bisq-network/bisq] We need to use the getMapOfAllData method for HistoricalDataStoreServices (#5030)

[chimp1984]

The map access to HistoricalDataStoreServices from the p2pDataStorage was incorrect. I has accessed the live map instead of all data. That has led that at addPersistableNetworkPayload the data got rebroadcast as it was assumed the data has not been already received.

How to test it?
- Add some logs in P2PDataStorage.addPersistableNetworkPayload to see if data gets added and broadcast
- Change the  delay at republishAllFiatAccounts in AccountAgeWitnessService otherwise it takes 20-60 sec. for republishing
- Create a new fresh regtest seed and new fresh app node. 
- Start the app. Create one fiat payment account. Shut down and copy the AccountAgeWitnessStore which must have 1 entry now and copy it to the resources and rename it to AccountAgeWitnessStore_1.5.0_BTC_REGTEST
- Restart seed node and app
- Now you should see repeated logs that the data gets added and broadcast

It is still not clear to me why we did not see much more AccountAgeWitness data but only one in massive numbers... 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5030

-- Commit Summary --

  * We need to use the getMapOfAllData method for HistoricalDataStoreServices

-- File Changes --

    M p2p/src/main/java/bisq/network/p2p/storage/persistence/AppendOnlyDataStoreService.java (7)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5030.patch
https://github.com/bisq-network/bisq/pull/5030.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5030
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201230/0733d701/attachment.htm>